Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN/INT: rename *possibly* -> *maybe* functions #15764

Closed
jreback opened this issue Mar 21, 2017 · 4 comments
Closed

CLN/INT: rename *possibly* -> *maybe* functions #15764

jreback opened this issue Mar 21, 2017 · 4 comments
Labels
Clean Internals Related to non-user accessible pandas implementation
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Mar 21, 2017

we have a mixed bag on naming this. Let's change possibly -> maybe. Keep everything else the same. (if you do the same search for maybe you will fine it to be far more common). Note that the usage of these functions will have to be renamed as well :>

(pandas) bash-3.2$ grep --include '*.py'  -R possibly pandas |grep def
pandas/computation/expr.py:    def _possibly_transform_eq_ne(self, node, left=None, right=None):
pandas/computation/expr.py:    def _possibly_downcast_constants(self, left, right):
pandas/computation/expr.py:    def _possibly_eval(self, binop, eval_in_python):
pandas/computation/expr.py:    def _possibly_evaluate_binop(self, op, op_class, lhs, rhs,
pandas/core/internals.py:def _possibly_compare(a, b, op):
pandas/indexes/base.py:    def _possibly_promote(self, other):
pandas/tests/types/test_cast.py:    def test_possibly_convert_objects_copy(self):
pandas/tseries/index.py:    def _possibly_promote(self, other):
pandas/tseries/tdi.py:    def _possibly_promote(self, other):
pandas/types/cast.py:def _possibly_convert_platform(values):
pandas/types/cast.py:def _possibly_downcast_to_dtype(result, dtype):
pandas/types/cast.py:def _possibly_cast_item(obj, item, dtype):
pandas/types/cast.py:def _possibly_convert_objects(values, convert_dates=True, convert_numeric=True,
pandas/types/cast.py:def _possibly_castable(arr):
pandas/types/cast.py:def _possibly_infer_to_datetimelike(value, convert_dates=False):
pandas/types/cast.py:def _possibly_cast_to_datetime(value, dtype, errors='raise'):
@jreback jreback added Clean Difficulty Novice Internals Related to non-user accessible pandas implementation labels Mar 21, 2017
@jreback jreback added this to the Next Major Release milestone Mar 21, 2017
@jreback
Copy link
Contributor Author

jreback commented Mar 21, 2017

cc @gfyoung

@gfyoung
Copy link
Member

gfyoung commented Mar 21, 2017

Seem reasonable.

@jreback
Copy link
Contributor Author

jreback commented Mar 21, 2017

also (separately), we should rename all of the functions in pandas.types.cast to remove the leading _. Just for some readability (they were like this because they were explicity private when I ported from pandas.core.common). pandas.types is private so this is not big deal now.

StanczakDominik added a commit to StanczakDominik/pandas that referenced this issue Mar 21, 2017
Also rename "private" functions in pandas.type.cast

Closes pandas-dev#15764
@StanczakDominik
Copy link
Contributor

Figured I would take a stab at this one.

@jreback jreback modified the milestones: 0.20.0, Next Major Release Mar 21, 2017
mattip pushed a commit to mattip/pandas that referenced this issue Apr 3, 2017
Also rename "private" functions in pandas.type.cast
closes pandas-dev#15764

Author: Dominik Stanczak <stanczakdominik@gmail.com>

Closes pandas-dev#15771 from StanczakDominik/rename-possibly and squashes the following commits:

486b932 [Dominik Stanczak] Cleanup missed linting errors
188c48b [Dominik Stanczak] CLN/INT: Rename _possibly to _maybe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants