change according to comments

pandas-dev · Oct 2, 2019 · b708d92 · b708d92
1 parent e790a59
commit b708d92
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/doc/source/reference/indexing.rst b/doc/source/reference/indexing.rst
@@ -166,7 +166,6 @@ Selecting
    Index.get_slice_bound
    Index.get_value
    Index.get_values
-   Index.set_value
    Index.isin
    Index.slice_indexer
    Index.slice_locs

diff --git a/doc/source/whatsnew/v1.0.0.rst b/doc/source/whatsnew/v1.0.0.rst
@@ -123,9 +123,9 @@ Documentation Improvements
 Deprecations
 ~~~~~~~~~~~~
 
-- :meth:`Index.set_values` has been deprecated. For a given index ``idx``, array ``arr``,
+- `Index.set_value` has been deprecated. For a given index ``idx``, array ``arr``,
   value in ``idx`` of ``idx_val`` and a new value of ``val``, ``idx.set_value(arr, idx_val, val)``
-  is equivalent to ``arr[idx.get_loc(idx_val) = val``, which should be used instead (:issue:`28621`).
+  is equivalent to ``arr[idx.get_loc(idx_val)] = val``, which should be used instead (:issue:`28621`).
 -
 
 .. _whatsnew_1000.prior_deprecations:

diff --git a/pandas/core/indexes/base.py b/pandas/core/indexes/base.py
@@ -205,7 +205,9 @@ class Index(IndexOpsMixin, PandasObject):
     """
 
     # tolist is not actually deprecated, just suppressed in the __dir__
-    _deprecations = DirNamesMixin._deprecations | frozenset(["tolist", "dtype_str"])
+    _deprecations = DirNamesMixin._deprecations | frozenset(
+        ["tolist", "dtype_str", "set_value"]
+    )
 
     # To hand over control to subclasses
     _join_precedence = 1