Skip to content

Commit

Permalink
TST: remove more ArrayManager skips for JSON IO (#41164)
Browse files Browse the repository at this point in the history
  • Loading branch information
jorisvandenbossche authored Apr 26, 2021
1 parent 99e2ee3 commit 2853622
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 50 deletions.
3 changes: 0 additions & 3 deletions pandas/tests/io/formats/test_printing.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@

import pandas._config.config as cf

import pandas.util._test_decorators as td

import pandas as pd

import pandas.io.formats.format as fmt
Expand Down Expand Up @@ -121,7 +119,6 @@ def test_ambiguous_width(self):
assert adjoined == expected


@td.skip_array_manager_not_yet_implemented # TODO(ArrayManager) JSON
class TestTableSchemaRepr:
@classmethod
def setup_class(cls):
Expand Down
9 changes: 2 additions & 7 deletions pandas/tests/io/test_common.py
Original file line number Diff line number Diff line change
Expand Up @@ -282,9 +282,7 @@ def test_read_fspath_all(self, reader, module, path, datapath):
("to_excel", {"engine": "xlwt"}, "xlwt"),
("to_feather", {}, "pyarrow"),
("to_html", {}, "os"),
pytest.param(
"to_json", {}, "os", marks=td.skip_array_manager_not_yet_implemented
),
("to_json", {}, "os"),
("to_latex", {}, "os"),
("to_pickle", {}, "os"),
("to_stata", {"time_stamp": pd.to_datetime("2019-01-01 00:00")}, "os"),
Expand Down Expand Up @@ -435,10 +433,7 @@ def test_is_fsspec_url():


@pytest.mark.parametrize("encoding", [None, "utf-8"])
@pytest.mark.parametrize(
"format",
["csv", pytest.param("json", marks=td.skip_array_manager_not_yet_implemented)],
)
@pytest.mark.parametrize("format", ["csv", "json"])
def test_codecs_encoding(encoding, format):
# GH39247
expected = tm.makeDataFrame()
Expand Down
4 changes: 0 additions & 4 deletions pandas/tests/io/test_compression.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,11 @@

import pytest

import pandas.util._test_decorators as td

import pandas as pd
import pandas._testing as tm

import pandas.io.common as icom

pytestmark = td.skip_array_manager_not_yet_implemented


@pytest.mark.parametrize(
"obj",
Expand Down
1 change: 0 additions & 1 deletion pandas/tests/io/test_fsspec.py
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,6 @@ def test_pickle_options(fsspectest):
tm.assert_frame_equal(df, out)


@td.skip_array_manager_not_yet_implemented # TODO(ArrayManager) JSON
def test_json_options(fsspectest, compression):
df = DataFrame({"a": [0]})
df.to_json(
Expand Down
11 changes: 1 addition & 10 deletions pandas/tests/io/test_gcs.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,7 @@ def ls(self, path, **kwargs):


@td.skip_if_no("gcsfs")
@pytest.mark.parametrize(
"format",
[
"csv",
pytest.param("json", marks=td.skip_array_manager_not_yet_implemented),
"parquet",
"excel",
"markdown",
],
)
@pytest.mark.parametrize("format", ["csv", "json", "parquet", "excel", "markdown"])
def test_to_read_gcs(gcs_buffer, format):
"""
Test that many to/read functions support GCS.
Expand Down
28 changes: 4 additions & 24 deletions pandas/tests/io/test_user_agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,12 +182,7 @@ def do_GET(self):
"responder, read_method, parquet_engine",
[
(CSVUserAgentResponder, pd.read_csv, None),
pytest.param(
JSONUserAgentResponder,
pd.read_json,
None,
marks=td.skip_array_manager_not_yet_implemented,
),
(JSONUserAgentResponder, pd.read_json, None),
(ParquetPyArrowUserAgentResponder, pd.read_parquet, "pyarrow"),
pytest.param(
ParquetFastParquetUserAgentResponder,
Expand All @@ -199,12 +194,7 @@ def do_GET(self):
(PickleUserAgentResponder, pd.read_pickle, None),
(StataUserAgentResponder, pd.read_stata, None),
(GzippedCSVUserAgentResponder, pd.read_csv, None),
pytest.param(
GzippedJSONUserAgentResponder,
pd.read_json,
None,
marks=td.skip_array_manager_not_yet_implemented,
),
(GzippedJSONUserAgentResponder, pd.read_json, None),
],
)
def test_server_and_default_headers(responder, read_method, parquet_engine):
Expand Down Expand Up @@ -233,12 +223,7 @@ def test_server_and_default_headers(responder, read_method, parquet_engine):
"responder, read_method, parquet_engine",
[
(CSVUserAgentResponder, pd.read_csv, None),
pytest.param(
JSONUserAgentResponder,
pd.read_json,
None,
marks=td.skip_array_manager_not_yet_implemented,
),
(JSONUserAgentResponder, pd.read_json, None),
(ParquetPyArrowUserAgentResponder, pd.read_parquet, "pyarrow"),
pytest.param(
ParquetFastParquetUserAgentResponder,
Expand All @@ -250,12 +235,7 @@ def test_server_and_default_headers(responder, read_method, parquet_engine):
(PickleUserAgentResponder, pd.read_pickle, None),
(StataUserAgentResponder, pd.read_stata, None),
(GzippedCSVUserAgentResponder, pd.read_csv, None),
pytest.param(
GzippedJSONUserAgentResponder,
pd.read_json,
None,
marks=td.skip_array_manager_not_yet_implemented,
),
(GzippedJSONUserAgentResponder, pd.read_json, None),
],
)
def test_server_and_custom_headers(responder, read_method, parquet_engine):
Expand Down
1 change: 0 additions & 1 deletion pandas/tests/io/xml/test_to_xml.py
Original file line number Diff line number Diff line change
Expand Up @@ -1172,7 +1172,6 @@ def test_style_to_string():
assert out_xml == out_str


@td.skip_array_manager_not_yet_implemented # TODO(ArrayManager) JSON
@td.skip_if_no("lxml")
def test_style_to_json():
xsl = """\
Expand Down

0 comments on commit 2853622

Please sign in to comment.