Skip to content

Commit

Permalink
CLN: pd.options.html.border (#26540)
Browse files Browse the repository at this point in the history
* CLN: pd.options.html.border

* Remove html.border option
  • Loading branch information
mroeschke authored May 27, 2019
1 parent 947126d commit 19f693f
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 21 deletions.
1 change: 1 addition & 0 deletions doc/source/whatsnew/v0.25.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ Removal of prior version deprecations/changes
- Removed the previously deprecated ``sheetname`` keyword in :func:`read_excel` (:issue:`16442`, :issue:`20938`)
- Removed the previously deprecated ``TimeGrouper`` (:issue:`16942`)
- Removed the previously deprecated ``parse_cols`` keyword in :func:`read_excel` (:issue:`16488`)
- Removed the previously deprecated ``pd.options.html.border`` (:issue:`16970`)

.. _whatsnew_0250.performance:

Expand Down
13 changes: 0 additions & 13 deletions pandas/core/config_init.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,6 @@ def use_numexpr_cb(key):
for the DataFrame HTML repr.
"""

pc_html_border_deprecation_warning = """\
html.border has been deprecated, use display.html.border instead
(currently both are identical)
"""

pc_html_use_mathjax_doc = """\
: boolean
When True, Jupyter notebook will process table contents using MathJax,
Expand Down Expand Up @@ -363,14 +358,6 @@ def is_terminal():
cf.register_option('html.use_mathjax', True, pc_html_use_mathjax_doc,
validator=is_bool)

with cf.config_prefix('html'):
cf.register_option('border', 1, pc_html_border_doc,
validator=is_int)

cf.deprecate_option('html.border', msg=pc_html_border_deprecation_warning,
rkey='display.html.border')


tc_sim_interactive_doc = """
: boolean
Whether to simulate interactive mode for purposes of testing
Expand Down
2 changes: 1 addition & 1 deletion pandas/core/frame.py
Original file line number Diff line number Diff line change
Expand Up @@ -2160,7 +2160,7 @@ def to_html(self, buf=None, columns=None, col_space=None, header=True,
Whether the generated HTML is for IPython Notebook.
border : int
A ``border=border`` attribute is included in the opening
`<table>` tag. Default ``pd.options.html.border``.
`<table>` tag. Default ``pd.options.display.html.border``.
.. versionadded:: 0.19.0
Expand Down
2 changes: 1 addition & 1 deletion pandas/io/formats/format.py
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ def to_html(self, classes=None, notebook=False, border=None):
Whether the generated HTML is for IPython Notebook.
border : int
A ``border=border`` attribute is included in the opening
``<table>`` tag. Default ``pd.options.html.border``.
``<table>`` tag. Default ``pd.options.display.html.border``.
.. versionadded:: 0.19.0
"""
Expand Down
6 changes: 0 additions & 6 deletions pandas/tests/io/formats/test_to_html.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,12 +244,6 @@ def test_to_html_border(option, result, expected):
assert expected in result


def test_display_option_warning():
with tm.assert_produces_warning(FutureWarning,
check_stacklevel=False):
pd.options.html.border


@pytest.mark.parametrize('biggie_df_fixture', ['mixed'], indirect=True)
def test_to_html(biggie_df_fixture):
# TODO: split this test
Expand Down

0 comments on commit 19f693f

Please sign in to comment.