Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add service file for pigeond #36

Merged

Conversation

aditya-manit
Copy link
Contributor

@aditya-manit aditya-manit commented Jul 7, 2022

palomachain/paloma#311

Background

Add service file for pigeond

Testing completed

  • Working on running pigeond using this service file, will update in comment in a while

@aditya-manit
Copy link
Contributor Author

Do not merge yet please, working on testing it. Will update here once done

Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aditya-manit Will you update without the sudo on the commands? We are tending to lean against sudo in the system commands themselves.

@aditya-manit
Copy link
Contributor Author

Okay sure, however by default permissions I believe sudo is required to restart systemctl services

@aditya-manit aditya-manit requested a review from taariq July 7, 2022 17:35
@aditya-manit
Copy link
Contributor Author

aditya-manit commented Jul 7, 2022

I think I was successfully able to run it as service

Jul 07 17:34:54 volume-testnet pigeon[13908]: *chirp chirp*
Jul 07 17:34:55 volume-testnet pigeon[13908]: time="2022-07-07T17:34:55Z" level=info msg="starting relayer"

However my node is still syncing, so as per my node, my address doesn't have any balance yet, so I am getting the below error

Jul 07 17:35:01 volume-testnet pigeon[13908]: time="2022-07-07T17:35:01Z" level=error msg="couldn't update external chain info" err="rpc error: code = NotFound desc = rpc error: code = NotFound desc = account paloma1egn65sacnwhn6fpptqudyzw4w3e46hpdzgpwad not found: key not found"
Jul 07 17:35:01 volume-testnet pigeon[13908]: Error: rpc error: code = NotFound desc = rpc error: code = NotFound desc = account paloma1egn65sacnwhn6fpptqudyzw4w3e46hpdzgpwad not found: key not found

It might take couple of more hours for my node to sync, so in case we wanna merge it asap, I'll recommend someone else to try setup it to verify, however I believe it's fine and will work when my node is synced. I'll update when its synced

README.md Outdated

#### Using systemd service

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

```shell

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean shell script ? I don't readme highlight just with shell

@measure-fi
Copy link
Contributor

@aditya-manit You don't need to make those changes, I can do a followup PR with my particulars. Overall readme changes look probably gtg.

@aditya-manit
Copy link
Contributor Author

Done with the changes

@aditya-manit aditya-manit requested a review from measure-fi July 7, 2022 18:21
measure-fi
measure-fi previously approved these changes Jul 7, 2022
@measure-fi measure-fi dismissed their stale review July 7, 2022 18:24

Leaving up to @taariq

@measure-fi measure-fi merged commit 7a68e64 into palomachain:master Jul 7, 2022
After=network-online.target

[Service]
Environment="PALOMA_KEYRING_PASS=$PALOMA_KEYRING_PASS"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this assume that the person running this command has $PALOMA_KEYRING_PASS and other env variables set when running this command? (@aditya-manit )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we are setting it here before running that command. Line 103 to line 110

Create service file

```shell script
tee <<EOF >/dev/null /etc/systemd/system/pigeond.service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aditya-manit this should be pigeon, not pigeond

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually I have seen a d suffix in binaries and services too, d for daemon I guess. We can remove it if we want to - nothing major.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the prefix d is a cosmos thing where they add the d at the end of a chain executable

Environment="PALOMA_KEYRING_PASS=$PALOMA_KEYRING_PASS"
Environment="ETH_RPC_URL=$ETH_RPC_URL"
Environment="ETH_PASSWORD=$ETH_PASSWORD"
Environment="ETH_SIGNING_KEY=$ETH_SIGNING_KEY"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the default env variables that we are exporting and based on the config file in this readme, you need to add VALIDATOR environment variable as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants