-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gravity Support #257
Gravity Support #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straight forward. I have left some comments, but mostly nitpicking.
There's also some TODOs left that we should address. Will there be a follow up ticket?
That being said, I suggest we wait before we drafted a new Pigeon release later today before bringing this back into master.
I think I've addressed all of your comments @byte-bandit. This PR will remain in draft until both it and the Paloma PR are ready to be merged. |
This should now be ready for merge. Paloma has been fully merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFG!
Related Github tickets
Background
This PR contains the necessary Pigeon-side functionality to for the Gravity Bridge.
This is broken at the moment because upstream paloma changes to keep-alive seem to have left an out-of-sync proto lookup. Merging #256 should fix this.
I've also skimped on the testing here because I've been pushing hard to get a working bridge. I suggest we go to testnet and circle back to complete testing before mainnet.
Testing completed
Breaking changes