Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravity Support #257

Merged
merged 16 commits into from
Sep 1, 2023
Merged

Conversation

MechanicalTyler
Copy link
Contributor

Related Github tickets

Background

This PR contains the necessary Pigeon-side functionality to for the Gravity Bridge.

  • Pigeon monitors Paloma for send-to-eth requests to an evm chain
  • Pigeon monitors the evm chains for events of send-to-paloma and attests those to paloma
  • The need to register orchestrator keys with paloma was removed because Pigeon already sends the necessary information to paloma

This is broken at the moment because upstream paloma changes to keep-alive seem to have left an out-of-sync proto lookup. Merging #256 should fix this.

I've also skimped on the testing here because I've been pushing hard to get a working bridge. I suggest we go to testnet and circle back to complete testing before mainnet.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes

Copy link
Collaborator

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straight forward. I have left some comments, but mostly nitpicking.

There's also some TODOs left that we should address. Will there be a follow up ticket?

That being said, I suggest we wait before we drafted a new Pigeon release later today before bringing this back into master.

@MechanicalTyler
Copy link
Contributor Author

I think I've addressed all of your comments @byte-bandit. This PR will remain in draft until both it and the Paloma PR are ready to be merged.

@MechanicalTyler MechanicalTyler marked this pull request as ready for review September 1, 2023 18:44
@MechanicalTyler
Copy link
Contributor Author

This should now be ready for merge. Paloma has been fully merged.

Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

@taariq taariq merged commit fac4dfe into palomachain:master Sep 1, 2023
@taariq taariq deleted the toaster/gravity-support branch September 1, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants