Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate dev server shutdown function #1873

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Deprecate dev server shutdown function #1873

merged 1 commit into from
Oct 16, 2020

Conversation

kx-chen
Copy link
Contributor

@kx-chen kx-chen commented Jul 2, 2020 •
edited
Loading

Closes #1752

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

davidism
davidism reviewed Jul 2, 2020
View reviewed changes
@kx-chen kx-chen force-pushed the 1752-dev-server-shutdown branch from 918c352 to f77bd39 Compare July 2, 2020 21:44
@kx-chen kx-chen marked this pull request as ready for review July 2, 2020 21:44
@kx-chen kx-chen force-pushed the 1752-dev-server-shutdown branch from f77bd39 to 570c14e Compare July 2, 2020 21:53
davidism
davidism reviewed Jul 2, 2020
View reviewed changes
@kx-chen kx-chen force-pushed the 1752-dev-server-shutdown branch 3 times, most recently from 9799be0 to a2647f5 Compare July 2, 2020 23:15
@mitsuhiko
Copy link
Contributor

I left a comment on the original issue about why I still think that functionality has some value.

@davidism davidism force-pushed the 1752-dev-server-shutdown branch from a2647f5 to 0258988 Compare October 16, 2020 22:26
@davidism davidism added this to the 2.0.0 milestone Oct 16, 2020
@davidism davidism merged commit ee56170 into pallets:master Oct 16, 2020
@davidism davidism deleted the 1752-dev-server-shutdown branch October 16, 2020 22:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidism davidism davidism left review comments

Assignees
No one assigned
Labels
server
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Deprecate dev server shutdown function
3 participants
@kx-chen @mitsuhiko @davidism