Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test on trio, fix all missing aclose related warnings #1960

Merged
merged 9 commits into from
May 11, 2024

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Apr 8, 2024

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@graingert graingert changed the title test on trio test on trio, fix all missing aclose related warnings Apr 8, 2024
@graingert graingert force-pushed the aclose-fixed-omnibus branch from c9d61b7 to 8ed364c Compare April 8, 2024 13:43
@graingert graingert marked this pull request as ready for review April 8, 2024 15:00
@davidism davidism added the async label May 11, 2024
@davidism davidism added this to the 3.1.5 milestone May 11, 2024
@davidism davidism force-pushed the aclose-fixed-omnibus branch from b105db5 to 6b04b6f Compare May 11, 2024 21:59
@davidism davidism changed the base branch from main to 3.1.x May 11, 2024 21:59
@davidism davidism closed this May 11, 2024
@davidism davidism reopened this May 11, 2024
@davidism davidism merged commit 1655128 into pallets:3.1.x May 11, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants