Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the validate of form should pass extra_validators #548

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Fix the validate of form should pass extra_validators #548

merged 1 commit into from
Jan 17, 2023

Conversation

HwangTaehyun
Copy link
Contributor

@HwangTaehyun HwangTaehyun commented Jan 17, 2023 •
edited
Loading

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in docs/changes.rst summarizing the change and linking to the issue. Add .. versionchanged:: entries in any relevant code docs.

@HwangTaehyun HwangTaehyun force-pushed the main branch 2 times, most recently from cd76312 to 84a303e Compare January 17, 2023 15:19
@HwangTaehyun
Copy link
Contributor Author

@azmeuk Should I add a version change?

@HwangTaehyun HwangTaehyun force-pushed the main branch 2 times, most recently from 3389f07 to 6fafba6 Compare January 17, 2023 15:57
@HwangTaehyun
Copy link
Contributor Author

HwangTaehyun commented Jan 17, 2023 •
edited
Loading

I passed flake8 step in locally, but pre-commit.ci failed.
image

@HwangTaehyun @jwag956 @chlrlrhs95
Fix the validate of form should pass extra_validators (pallets-eco#547)
135b0e6 
Co-authored-by: jwag956 <jwag.wagner@gmail.com>
Co-authored-by: chlrlrhs95 <chlrlrhs95@naver.com>
@azmeuk
Copy link
Member

azmeuk commented Jan 17, 2023

Thank you!

@azmeuk azmeuk merged commit 64f835c into pallets-eco:main Jan 17, 2023
azmeuk added a commit that referenced this pull request Jan 17, 2023
@azmeuk
CHANGELOG for #548
9a8a411
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extra_validators change breaks many many forms
2 participants
@HwangTaehyun @azmeuk