-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple file validation #338
Conversation
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
==========================================
+ Coverage 99.67% 99.69% +0.02%
==========================================
Files 18 18
Lines 911 986 +75
Branches 74 82 +8
==========================================
+ Hits 908 983 +75
Misses 3 3
Continue to review full report at Codecov.
|
I experimented with this back when I made the WTForms PR, I'm trying to remember the design decisions I made. I think that while the fields were separate so it was clear what was intended, I was trying to make the validators work for both single and multiple files (rather than adding extra validators or a Also might be interesting to add a test of the |
Sounds good to me. |
I'd love to see this merged. Anything I can help with? |
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
==========================================
- Coverage 97.97% 96.63% -1.34%
==========================================
Files 18 18
Lines 936 1011 +75
Branches 73 81 +8
==========================================
+ Hits 917 977 +60
- Misses 17 31 +14
- Partials 2 3 +1
Continue to review full report at Codecov.
|
Any chance of this being merged? :) |
Hoping the same. @azmeuk can you review this please? |
This PR may not be merged. I was planning to implement what David recommended as an alternative to this PR in January, but I was too busy with work. Maybe I will have time to make another PR next month. BTW, I'm also happy to review a PR! |
39f2911
to
a7676eb
Compare
Hi guys, I finally re-implemented this in #556. With the new PR, the |
Add
MultipleFileField
,FilesRequired
,FilesAllowed
to support multiple files validation.Closes #337