fix(wabe-stripe): return code when create stripe coupon (#117)

* fix(wabe-stripe): return code when create stripe coupon * feat: improve documentation
palixir · Dec 26, 2024 · f2f0299 · f2f0299
1 parent 61dd791
commit f2f0299
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 10 deletions.
diff --git a/packages/wabe-documentation/docs/payment/index.md b/packages/wabe-documentation/docs/payment/index.md
@@ -48,7 +48,7 @@ You can create a coupon using the `createCoupon` method.
 
 ```ts
 const fn = async (context: WabeContext<any>) => {
-  const couponId = await context.wabe.controllers.payment.createCoupon({
+  const {code, id: stripeId} = await context.wabe.controllers.payment.createCoupon({
     duration: 'repeating',
     durationInMonths: 3,
     name: 'MYCOUPON',
@@ -61,7 +61,7 @@ Or with fixed amount:
 
 ```ts
 const fn = async (context: WabeContext<any>) => {
-  const couponId = await context.wabe.controllers.payment.createCoupon({
+  const {code, id: stripeId} = await context.wabe.controllers.payment.createCoupon({
     duration: 'forever',
     currency: Currency.EUR,
     amountOff: 100,
@@ -76,7 +76,7 @@ You can create a promotion code from a coupon using the `createPromotionCode` me
 
 ```ts
 const fn = async (context: WabeContext<any>) => {
-  const promotionCode = await context.wabe.controllers.payment.createPromotionCode({
+  const {code, id: stripeId} = await context.wabe.controllers.payment.createPromotionCode({
     couponId: 'coupon_123',
     code: 'MYCODE',
   })

diff --git a/packages/wabe-stripe/package.json b/packages/wabe-stripe/package.json
@@ -1,6 +1,6 @@
 {
   "name": "wabe-stripe",
-  "version": "0.5.9",
+  "version": "0.5.10",
   "description": "Stripe payment adapter for Wabe",
   "homepage": "https://wabe.dev",
   "author": {

diff --git a/packages/wabe-stripe/src/index.test.ts b/packages/wabe-stripe/src/index.test.ts
@@ -140,7 +140,7 @@ describe('wabe-stripe', () => {
       percent_off: undefined,
     } as never)
 
-    const couponId = await adapter.createCoupon({
+    const { id, code } = await adapter.createCoupon({
       amountOff: 1000,
       currency: Currency.EUR,
       duration: 'forever',
@@ -161,7 +161,8 @@ describe('wabe-stripe', () => {
       percent_off: undefined,
     })
 
-    expect(couponId).toEqual('coupon_123')
+    expect(id).toEqual('coupon_123')
+    expect(code).toEqual('Coupon 1')
   })
 
   it('should create a promotion code', async () => {

diff --git a/packages/wabe-stripe/src/index.ts b/packages/wabe-stripe/src/index.ts
@@ -62,7 +62,7 @@ export class StripeAdapter implements PaymentAdapter {
 
     if (!coupon.id) throw new Error('Error creating Stripe coupon')
 
-    return coupon.id
+    return { id: coupon.id, code: coupon.name || '' }
   }
 
   async createPromotionCode({

diff --git a/packages/wabe/package.json b/packages/wabe/package.json
@@ -1,6 +1,6 @@
 {
   "name": "wabe",
-  "version": "0.5.12",
+  "version": "0.5.13",
   "description": "Your backend in minutes not days",
   "homepage": "https://wabe.dev",
   "author": {

diff --git a/packages/wabe/src/payment/DevAdapter.ts b/packages/wabe/src/payment/DevAdapter.ts
@@ -14,7 +14,7 @@ export class PaymentDevAdapter implements PaymentAdapter {
 
   // biome-ignore lint/suspicious/useAwait: false
   async createCoupon() {
-    return ''
+    return { code: '', id: '' }
   }
 
   // biome-ignore lint/suspicious/useAwait: false

diff --git a/packages/wabe/src/payment/interface.ts b/packages/wabe/src/payment/interface.ts
@@ -192,7 +192,9 @@ export interface PaymentAdapter {
    * @param options CreateCouponOptions
    * @returns id The coupon id
    */
-  createCoupon: (options: CreateCouponOptions) => Promise<string>
+  createCoupon: (
+    options: CreateCouponOptions,
+  ) => Promise<{ code: string; id: string }>
   /**
    * Disable a promotion code
    * @param options DeletePromotionCodeOptions