fix(wabe): input of mutation should always be required (#31)

palixir · Sep 6, 2024 · dbae1b9 · dbae1b9
1 parent db703a7
commit dbae1b9
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 45 deletions.
diff --git a/packages/wabe/generated/schema.graphql b/packages/wabe/generated/schema.graphql
@@ -778,48 +778,48 @@ type MeOutput {
 
 type Mutation {
   """User class"""
-  createUser(input: CreateUserInput): CreateUserPayload
+  createUser(input: CreateUserInput!): CreateUserPayload
 
   """User class"""
-  createUsers(input: CreateUsersInput): UserConnection!
+  createUsers(input: CreateUsersInput!): UserConnection!
 
   """User class"""
-  updateUser(input: UpdateUserInput): UpdateUserPayload
+  updateUser(input: UpdateUserInput!): UpdateUserPayload
 
   """User class"""
-  updateUsers(input: UpdateUsersInput): UserConnection!
+  updateUsers(input: UpdateUsersInput!): UserConnection!
 
   """User class"""
-  deleteUser(input: DeleteUserInput): DeleteUserPayload
+  deleteUser(input: DeleteUserInput!): DeleteUserPayload
 
   """User class"""
-  deleteUsers(input: DeleteUsersInput): UserConnection!
-  createPost(input: CreatePostInput): CreatePostPayload
-  createPosts(input: CreatePostsInput): PostConnection!
-  updatePost(input: UpdatePostInput): UpdatePostPayload
-  updatePosts(input: UpdatePostsInput): PostConnection!
-  deletePost(input: DeletePostInput): DeletePostPayload
-  deletePosts(input: DeletePostsInput): PostConnection!
-  create_Session(input: Create_SessionInput): Create_SessionPayload
-  create_Sessions(input: Create_SessionsInput): _SessionConnection!
-  update_Session(input: Update_SessionInput): Update_SessionPayload
-  update_Sessions(input: Update_SessionsInput): _SessionConnection!
-  delete_Session(input: Delete_SessionInput): Delete_SessionPayload
-  delete_Sessions(input: Delete_SessionsInput): _SessionConnection!
-  createRole(input: CreateRoleInput): CreateRolePayload
-  createRoles(input: CreateRolesInput): RoleConnection!
-  updateRole(input: UpdateRoleInput): UpdateRolePayload
-  updateRoles(input: UpdateRolesInput): RoleConnection!
-  deleteRole(input: DeleteRoleInput): DeleteRolePayload
-  deleteRoles(input: DeleteRolesInput): RoleConnection!
-  createMutation(input: CreateMutationInput): Boolean!
-  customMutation(input: CustomMutationInput): Int
-  secondCustomMutation(input: SecondCustomMutationInput): Int
-  signInWith(input: SignInWithInput): SignInWithOutput
-  signUpWith(input: SignUpWithInput): SignUpWithOutput
+  deleteUsers(input: DeleteUsersInput!): UserConnection!
+  createPost(input: CreatePostInput!): CreatePostPayload
+  createPosts(input: CreatePostsInput!): PostConnection!
+  updatePost(input: UpdatePostInput!): UpdatePostPayload
+  updatePosts(input: UpdatePostsInput!): PostConnection!
+  deletePost(input: DeletePostInput!): DeletePostPayload
+  deletePosts(input: DeletePostsInput!): PostConnection!
+  create_Session(input: Create_SessionInput!): Create_SessionPayload
+  create_Sessions(input: Create_SessionsInput!): _SessionConnection!
+  update_Session(input: Update_SessionInput!): Update_SessionPayload
+  update_Sessions(input: Update_SessionsInput!): _SessionConnection!
+  delete_Session(input: Delete_SessionInput!): Delete_SessionPayload
+  delete_Sessions(input: Delete_SessionsInput!): _SessionConnection!
+  createRole(input: CreateRoleInput!): CreateRolePayload
+  createRoles(input: CreateRolesInput!): RoleConnection!
+  updateRole(input: UpdateRoleInput!): UpdateRolePayload
+  updateRoles(input: UpdateRolesInput!): RoleConnection!
+  deleteRole(input: DeleteRoleInput!): DeleteRolePayload
+  deleteRoles(input: DeleteRolesInput!): RoleConnection!
+  createMutation(input: CreateMutationInput!): Boolean!
+  customMutation(input: CustomMutationInput!): Int
+  secondCustomMutation(input: SecondCustomMutationInput!): Int
+  signInWith(input: SignInWithInput!): SignInWithOutput
+  signUpWith(input: SignUpWithInput!): SignUpWithOutput
   signOut: Boolean
-  refresh(input: RefreshInput): RefreshSessionOutput
-  verifyChallenge(input: VerifyChallengeInput): Boolean
+  refresh(input: RefreshInput!): RefreshSessionOutput
+  verifyChallenge(input: VerifyChallengeInput!): Boolean
 }
 
 type CreateUserPayload {

diff --git a/packages/wabe/src/authentication/index.test.ts b/packages/wabe/src/authentication/index.test.ts
@@ -814,7 +814,7 @@ const graphql = {
 		}
 	`,
   refresh: gql`
-		mutation refresh($input: RefreshInput) {
+		mutation refresh($input: RefreshInput!) {
   		refresh(input: $input) {
     		accessToken
     		refreshToken

diff --git a/packages/wabe/src/graphql/GraphQLSchema.test.ts b/packages/wabe/src/graphql/GraphQLSchema.test.ts
@@ -973,7 +973,7 @@ describe('GraphqlSchema', () => {
         name: 'createTestClass',
       }),
     ).toEqual({
-      input: { input: 'CreateTestClassInput' },
+      input: { input: 'CreateTestClassInput!' },
       output: 'CreateTestClassPayload',
     })
   })
@@ -986,7 +986,7 @@ describe('GraphqlSchema', () => {
         name: 'createTestClasses',
       }),
     ).toEqual({
-      input: { input: 'CreateTestClassesInput' },
+      input: { input: 'CreateTestClassesInput!' },
       output: 'TestClassConnection!',
     })
   })
@@ -999,7 +999,7 @@ describe('GraphqlSchema', () => {
         name: 'updateTestClass',
       }),
     ).toEqual({
-      input: { input: 'UpdateTestClassInput' },
+      input: { input: 'UpdateTestClassInput!' },
       output: 'UpdateTestClassPayload',
     })
   })
@@ -1012,7 +1012,7 @@ describe('GraphqlSchema', () => {
         name: 'updateTestClasses',
       }),
     ).toEqual({
-      input: { input: 'UpdateTestClassesInput' },
+      input: { input: 'UpdateTestClassesInput!' },
       output: 'TestClassConnection!',
     })
   })
@@ -1025,7 +1025,7 @@ describe('GraphqlSchema', () => {
         name: 'deleteTestClass',
       }),
     ).toEqual({
-      input: { input: 'DeleteTestClassInput' },
+      input: { input: 'DeleteTestClassInput!' },
       output: 'DeleteTestClassPayload',
     })
   })
@@ -1038,7 +1038,7 @@ describe('GraphqlSchema', () => {
         name: 'deleteTestClasses',
       }),
     ).toEqual({
-      input: { input: 'DeleteTestClassesInput' },
+      input: { input: 'DeleteTestClassesInput!' },
       output: 'TestClassConnection!',
     })
   })

diff --git a/packages/wabe/src/graphql/GraphQLSchema.ts b/packages/wabe/src/graphql/GraphQLSchema.ts
@@ -532,7 +532,7 @@ export class GraphQLSchema {
           type: required ? new GraphQLNonNull(outputType) : outputType,
           args:
             numberOfFieldsInInput > 0
-              ? { input: { type: graphqlInput } }
+              ? { input: { type: new GraphQLNonNull(graphqlInput) } }
               : undefined,
           description: currentMutation.description,
           resolve: currentMutation.resolve,
@@ -736,7 +736,7 @@ export class GraphQLSchema {
       [`create${className}`]: {
         type: createPayloadType,
         description: object.description,
-        args: { input: { type: createInputType } },
+        args: { input: { type: new GraphQLNonNull(createInputType) } },
         resolve: (root, args, ctx, info) =>
           mutationToCreateObject(
             root,
@@ -749,7 +749,7 @@ export class GraphQLSchema {
       [`create${pluralize(className)}`]: {
         type: new GraphQLNonNull(connectionObject),
         description: object.description,
-        args: { input: { type: createsInputType } },
+        args: { input: { type: new GraphQLNonNull(createsInputType) } },
         resolve: (root, args, ctx, info) =>
           mutationToCreateMultipleObjects(
             root,
@@ -762,7 +762,7 @@ export class GraphQLSchema {
       [`update${className}`]: {
         type: updatePayloadType,
         description: object.description,
-        args: { input: { type: updateInputType } },
+        args: { input: { type: new GraphQLNonNull(updateInputType) } },
         resolve: (root, args, ctx, info) =>
           mutationToUpdateObject(
             root,
@@ -775,7 +775,7 @@ export class GraphQLSchema {
       [`update${pluralize(className)}`]: {
         type: new GraphQLNonNull(connectionObject),
         description: object.description,
-        args: { input: { type: updatesInputType } },
+        args: { input: { type: new GraphQLNonNull(updatesInputType) } },
         resolve: (root, args, ctx, info) =>
           mutationToUpdateMultipleObjects(
             root,
@@ -790,7 +790,7 @@ export class GraphQLSchema {
         description: object.description,
         args: {
           input: {
-            type: deleteInputType,
+            type: new GraphQLNonNull(deleteInputType),
           },
         },
         resolve: (root, args, ctx, info) =>
@@ -805,7 +805,7 @@ export class GraphQLSchema {
       [`delete${pluralize(className)}`]: {
         type: new GraphQLNonNull(connectionObject),
         description: object.description,
-        args: { input: { type: deletesInputType } },
+        args: { input: { type: new GraphQLNonNull(deletesInputType) } },
         resolve: (root, args, ctx, info) =>
           mutationToDeleteMultipleObjects(
             root,