fix(wabe): fix coupon name, no allow_promotion when couponId (#129)

palixir · Jan 2, 2025 · 818eb39 · 818eb39
1 parent 14c158c
commit 818eb39
Show file tree

Hide file tree

Showing 5 changed files with 86 additions and 4 deletions.
diff --git a/packages/wabe-stripe/package.json b/packages/wabe-stripe/package.json
@@ -1,6 +1,6 @@
 {
   "name": "wabe-stripe",
-  "version": "0.5.12",
+  "version": "0.5.13",
   "description": "Stripe payment adapter for Wabe",
   "homepage": "https://wabe.dev",
   "author": {

diff --git a/packages/wabe-stripe/src/index.test.ts b/packages/wabe-stripe/src/index.test.ts
@@ -741,6 +741,75 @@ describe('wabe-stripe', () => {
     })
   })
 
+  it('should not provide allo_promotion_codes and discounts in the same request', async () => {
+    const adapter = new StripeAdapter('API_KEY')
+
+    mockListCustomers.mockResolvedValue({
+      data: [
+        {
+          id: 'cus_123',
+          email: 'test@wabe.dev',
+        },
+      ],
+    } as never)
+
+    mockCreatePayment.mockResolvedValue({
+      url: 'https://test.com',
+    } as never)
+
+    await adapter.createPayment({
+      customerEmail: 'lucas.coratger@gmail.com',
+      currency: Currency.EUR,
+      paymentMethod: ['card'],
+      products: [
+        {
+          name: 'Product 1',
+          unitAmount: 1000,
+          quantity: 1,
+        },
+      ],
+      paymentMode: PaymentMode.subscription,
+      successUrl: 'https://wabe.dev',
+      cancelUrl: 'https://wabe.dev',
+      promotionCodeId: 'PROMO_123',
+    })
+
+    expect(mockCreatePayment).toHaveBeenCalledTimes(1)
+    expect(mockCreatePayment).toHaveBeenCalledWith({
+      customer: 'cus_123',
+      line_items: [
+        {
+          price_data: {
+            currency: 'eur',
+            product_data: {
+              name: 'Product 1',
+            },
+            unit_amount: 1000,
+            recurring: {
+              interval: 'month',
+            },
+          },
+          quantity: 1,
+        },
+      ],
+      payment_method_types: ['card'],
+      mode: 'subscription',
+      success_url: 'https://wabe.dev',
+      cancel_url: 'https://wabe.dev',
+      automatic_tax: {
+        enabled: false,
+      },
+      invoice_creation: {
+        enabled: true,
+      },
+      discounts: [
+        {
+          promotion_code: 'PROMO_123',
+        },
+      ],
+    })
+  })
+
   it('should throw an error if the session url is not returned by Stripewhen creating a payment', () => {
     const adapter = new StripeAdapter('API_KEY')
 

diff --git a/packages/wabe-stripe/src/index.ts b/packages/wabe-stripe/src/index.ts
@@ -199,6 +199,7 @@ export class StripeAdapter implements PaymentAdapter {
     createInvoice = true,
     allowPromotionCode = true,
     promotionCodeId,
+    couponCodeId,
   }: CreatePaymentOptions) {
     const customersWithSameEmail = await this.stripe.customers.list({
       email: customerEmail,
@@ -239,7 +240,9 @@ export class StripeAdapter implements PaymentAdapter {
       invoice_creation: {
         enabled: createInvoice,
       },
-      allow_promotion_codes: allowPromotionCode,
+      ...(!promotionCodeId && !couponCodeId
+        ? { allow_promotion_codes: allowPromotionCode }
+        : {}),
       ...(automaticTax
         ? {
             billing_address_collection: 'required',
@@ -252,7 +255,16 @@ export class StripeAdapter implements PaymentAdapter {
         ? {
             discounts: [
               {
-                coupon: promotionCodeId,
+                promotion_code: promotionCodeId,
+              },
+            ],
+          }
+        : {}),
+      ...(couponCodeId
+        ? {
+            discounts: [
+              {
+                coupon: couponCodeId,
               },
             ],
           }

diff --git a/packages/wabe/package.json b/packages/wabe/package.json
@@ -1,6 +1,6 @@
 {
   "name": "wabe",
-  "version": "0.5.16",
+  "version": "0.5.17",
   "description": "Your backend in minutes not days",
   "homepage": "https://wabe.dev",
   "author": {

diff --git a/packages/wabe/src/payment/interface.ts b/packages/wabe/src/payment/interface.ts
@@ -105,6 +105,7 @@ export type CreatePaymentOptions = {
   createInvoice?: boolean
   allowPromotionCode?: boolean
   promotionCodeId?: string
+  couponCodeId?: string
 }
 
 export type InitWebhookOptions = {