This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fix bug where await expressions were marked as unused #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| const { expression } = node; | ||
| const { kind } = expression; | ||
| const isValidStandAloneExpressionKind = kind === ts.SyntaxKind.DeleteExpression |
There was a problem hiding this comment.
nit: "standalone" is one word, not 2, and I think Kind is useless in this identifier
i.e. isValidStandaloneExpression
There was a problem hiding this comment.
Haha good call, meant to look that one up actually
|
feel free to merge after small rename 👍 |
f1750cf to
7f00366
Compare
jkillian
added a commit
that referenced
this pull request
Jan 9, 2016
Fix bug where await expressions were marked as unused
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #887