Automatic tslint.json generation with --init command #871
Conversation
|
|
Added test. As far as a default config, I think it should be pretty conservative in what is enabled |
|
Added a commit with a proposed reasonable default config. I looked at our settings as well as the rules TypeScript used as a baseline, and ruling out rules that are more aggressive (or bug prone, like no-unused-variable). |
| "semicolon": true | ||
| "no-var-keyword": true, | ||
| "one-line": [true, "check-open-brace", "check-whitespace"], | ||
| "quotemark": [true, "single"], |
There was a problem hiding this comment.
why single? we use double quotes and so does the TS team. let's change it back.
There was a problem hiding this comment.
Single quotes are scientifically proven to be easier for humans on standard english keyboards to type!
There was a problem hiding this comment.
meh, but it doesn't make sense to have the default config be different from our own code like this. we should discuss moving to single quotes elsewhere... we choose double to make it easier to switch back-and-forth between languages like Java to TS. many others, including the compiler team, use double quotes for the same reason.
|
[Changes made] |
|
👍 |
Automatic tslint.json generation with --init command
Implements #717
A simple implementation of a feature to generate a tslint.json file for users. This PR is very limited in scope - there are lots of ways for this to be improved in the future.
This feature intentionally isn't added to the README yet, that can be done once a better default configuration is settled on.