This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Use explicit exports for formatters. #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 reverse issue link: microsoft/TypeScript#6008 |
adidahiya
added a commit
that referenced
this pull request
Dec 10, 2015
…rExports Use explicit exports for formatters.
|
🎉 Any clue when this'll make it's way to the |
|
We definitely don't want to be breaking TS nightly builds! A |
|
@DanielRosenwasser just published 3.2.0-dev.2 to |
|
Awesome! I'll give it a shot now. |
|
Everything seems to be working. Given that, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all of the formatters are named
Formatter, this is going to break in TypeScript 1.8 and we noticed it when nightlies weren't getting published.