This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fix #612 #801
Merged
Fix #612 #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| constructor(sourceFile: ts.SourceFile, options: Lint.IOptions) { | ||
| super(sourceFile, options); | ||
| this.validateConstructors = this.hasOption("check-constructor"); | ||
| this.validateAccessors = this.hasOption("check-accessor"); |
There was a problem hiding this comment.
let's just inline the this.hasOption calls for better readability
|
looks pretty good overall; just left small comments for revision. the travis CI failure looks like a flake; it ought to work on your next push. |
|
Sounds good. I'll get those changes in soon |
|
👍 |
adidahiya
added a commit
that referenced
this pull request
Nov 18, 2015
jkillian
referenced
this pull request
Nov 18, 2015
- Set typescript peer dependency to >= 1.6.2 - Set typescript dev dependency to latest (1.6.2) - Some whitespace cleanup in CHANGELOG.md
adidahiya
added a commit
that referenced
this pull request
Nov 20, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes member-access checking for object literals and nested objects, #612