-
Notifications
You must be signed in to change notification settings - Fork 885
Add the option allow-empty-functions in no-empty #3624
Conversation
Thanks for your interest in palantir/tslint, @markvincze! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
I signed the CLA. |
Any updates? |
@ikokostya, |
Hello everyone- tslint has recently gotten some new maintainers - myself as one of them. Unfortunately it’s taking us a while to ramp up on everything and get through all the issues, but we’re starting to merge things in and try to bring tslint back to a stable state. Hold tight, we’ll get to this PR as soon as we can. |
Hey @johnwiseheart, great news! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good to me, thanks @markvincze!
PR checklist
Overview of change:
Introduces option to allow function declarations to be empty while using
no-empty
.Is there anything you'd like reviewers to focus on?
This is my first PR to tslint, so any feedback is welcome.
I was a bit unsure if I did the correct setup for the
options
property (anarray
with ananyOf
of the two strings).CHANGELOG.md entry:
[enhancement] Introduces option to allow function declarations to be empty while using
no-empty
.