completed-docs: Added option to check get and set accessors.

[reduckted]

PR checklist

• Addresses an existing issue: completed-docs doesn't cover Accessors #3479
• New feature, bugfix, or enhancement
  • Includes tests
• Documentation update

Overview of change:

The "properties" for the completed-docs rule now checks GetAccessor and SetAccessor node types.

CHANGELOG.md entry:

[enhancement] "properties" option for completed-docs rule now checks getter and setter accessors.

[ajafff]

Added an "accessor" option to the completed-docs rule that causes GetAccessor and SetAccessor node types to be checked for JSDoc comments.

To the consumer it doesn't matter if it's an accessor or a "real" property. That's an implementation detail.
I think checking accessors should be enabled by enabling "properties".

[reduckted]

Not sure why the "testNext" configuration is failing. The "trailing-comma" rule has failing tests, but my changes have nothing to do with that. 😕

[ajafff]

@reduckted it's a bug in typescript@next, see #3494 (comment)

[ajafff]

Code LGTM
Please add a test with accessors in an object literal. There should be no docs required?

[reduckted]

@ajafff Ah, good catch. Accessors in object literals were expected to have documentation comments. I've made the rule skip over them now.

Properties on object literals didn't require documentation. I'm not too familiar with the entire TypeScript syntax tree, but I'm guessing properties in object literals and properties in classes don't use the same SyntaxKind.

[ajafff]

@reduckted

I'm guessing properties in object literals and properties in classes don't use the same SyntaxKind.

That's correct. But MethodDeclaration is the same for both.

[ajafff]

thanks @reduckted

I'll open a follow-up PR to exclude method declarations in object literals