This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Converted completed-docs rule to use a function instead of a walker #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No rule logic is changed: just the types of scoping used to call it.
ajafff
approved these changes
Nov 8, 2017
| private static modifierAliases: { [i: string]: string } = { | ||
| export: "exported", | ||
| }; | ||
| const modifierAliases: { [i: string]: string } = { |
There was a problem hiding this comment.
: string | undefined to be precise
|
Unrelated build failures: |
|
@JoshuaKGoldberg please hit the "Rebuild" button in CircleCI and ping me when it's done. After CI is green I can merge this. |
|
@ajafff could you? I don't have permissions to.
|
|
Neither do I. Maybe if you log into CircleCI again. |
ajafff
suggested changes
Nov 13, 2017
tslint.json
Outdated
| @@ -4,6 +4,8 @@ | |||
| }, | |||
| "extends": "tslint:all", | |||
| "rules": { | |||
| "linebreak-style": false, | |||
There was a problem hiding this comment.
This was probably not intended to be commited. Please revert this change.
ajafff
approved these changes
Nov 13, 2017
|
Thanks @JoshuaKGoldberg |
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No rule logic is changed: just the types of scoping used to call it.