no-shadowed-variable: ignore declaration files and ambient modules #3387
Conversation
[bugfix] `no-shadowed-variable` now excludes declaration files and ambient modules Fixes: #3088
| @@ -0,0 +1,7 @@ | |||
| // no errors in declaration files | |||
There was a problem hiding this comment.
i'm not sure about this -- why should we skip declaration files entirely? Is the idea that declaration files have to adhere to all the idiosyncrasies of their corresponding JS source and therefore can't help it if it has shadowed names, so it's impossible to avoid the shadowing unless the JS is fixed as well?
There was a problem hiding this comment.
Exactly. We skip declartation files for the same reason we ignore module augmentations: they model something that already exists. Like you said:
declaration files have to adhere to all the idiosyncrasies of their corresponding JS source and therefore can't help it if it has shadowed names, so it's impossible to avoid the shadowing unless the JS is fixed as well?
There was a problem hiding this comment.
cool, we're on the same page.
|
merging because this passes the old status checks (before we split into multiple builds) |
…alantir#3387) [bugfix] `no-shadowed-variable` now excludes declaration files and ambient modules Fixes: palantir#3088
PR checklist
Overview of change:
[bugfix]
no-shadowed-variablenow excludes declaration files and ambient modulesFixes: #3088
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry: