This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
vsoFormatter: don't duplicate output for fixed failures #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[bugfix] `vso` formatter no longer duplicates output for fixed failures
adidahiya
reviewed
Oct 20, 2017
test/formatters/vsoFormatterTests.ts
Outdated
| @@ -45,7 +45,7 @@ describe("VSO Formatter", () => { | |||
| getFailureString(TEST_FILE, 2, 12, "mid failure", "mid-name") + | |||
| getFailureString(TEST_FILE, 9, 2, "last failure", "last-name"); | |||
|
|
|||
| const actualResult = formatter.format(failures); | |||
| const actualResult = formatter.format(failures, failures); | |||
There was a problem hiding this comment.
this is confusing to read -- the second argument is fixes but it's called failures here. you might want to write a separate test to validate that passing in fixes as a second argument doesn't create excess formatter output, or at least leave a comment here
There was a problem hiding this comment.
I created a separate test where I duplicate the failures array to pass them as fixes
adidahiya
approved these changes
Oct 20, 2017
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
[bugfix]
vsoformatter no longer duplicates output for fixed failuresI noticed this while looking through the formatters to find out how the
fixesparameter is used. Obviously this formatter got it wrong...Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry: