This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
await-promise: check for-await-of #3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[bugfix] `--test` works correctly with any `compilerOptions.target`
adidahiya
approved these changes
Oct 20, 2017
| function isPromiseType(type: ts.Type): boolean { | ||
| const { target } = type as ts.TypeReference; | ||
| return target !== undefined && target.symbol !== undefined && promiseTypes.has(target.symbol.name); | ||
| function containsType(type: ts.Type, predicate: (name: string) => boolean): boolean { |
There was a problem hiding this comment.
seems like a utility we might want in language/utils.ts, what do you think?
There was a problem hiding this comment.
Makes sense. We also use a similar function in return-undefined and probably in other rules, too.
We need to find a better abstraction than the one used here to make it work for other cases. Will do that in a follow-up PR.
src/rules/awaitPromiseRule.ts
Outdated
| @@ -42,6 +42,7 @@ export class Rule extends Lint.Rules.TypedRule { | |||
| /* tslint:enable:object-literal-sort-keys */ | |||
|
|
|||
| public static FAILURE_STRING = "'await' of non-Promise."; | |||
| public static FAILURE_FOR_AWAIT_OF = "'for-await-of' of non-AsyncIterable."; | |||
There was a problem hiding this comment.
I realized both of these error messages are a bit too terse -- how about
- "Invalid 'await' of a non-Promise value"
- "Invalid 'for-await-of' of a non-AsyncIterable value"
adidahiya
approved these changes
Oct 20, 2017
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
[enhancement]
await-promiseenforces thatfor-await-ofis only used withAsyncIterableIteratorFixes: #3232
Is there anything you'd like reviewers to focus on?
Depends on: #3296
CHANGELOG.md entry: