This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
no-empty-interface: allow providing type arguments for extended type #3260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
[bugfix]
no-empty-interface
allows providing type arguments for extended typeFixes: #3256
Is there anything you'd like reviewers to focus on?
The rule now ignores every interface whose parent has type arguments. That leads to some false-negatives:
There will be no error on any of these declarations. One might expect errors on
Bad
andBad2
(and maybe even onProbablyGood
,ProbablyGood2
if the base type has the same default and/or constraint) but that requires the type checker to find out about all type parameters of the base type.I don't know if these rare cases are worth the effort. Anyways, that should be done in a separate PR.
CHANGELOG.md entry: