Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

config: use resolved exclude pattern #3205

Merged
merged 2 commits into from
Sep 11, 2017
Merged

config: use resolved exclude pattern #3205

merged 2 commits into from
Sep 11, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Sep 7, 2017

PR checklist

Overview of change:

Resolve the exclude patterns specified in tslint.json with the directory of the config file.
If /foo/tslint.json excludes baz.ts we only exclude /foo/baz.ts and still lint /foo/bar/baz.ts.

Is there anything you'd like reviewers to focus on?

This should definitely be merged before the v5.8.0 release to avoid breaking changes.

Globstar patterns are also resolved: **/*.d.ts becomes /dir/of/config/**/*.d.ts.
That might cause unexpected results when the config file is located somewhere else, e.g. the user home.

CHANGELOG.md entry:

@ajafff ajafff added this to the TSLint v5.8 milestone Sep 7, 2017
@adidahiya adidahiya merged commit 347e836 into palantir:master Sep 11, 2017
HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this pull request Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants