Ordered-Imports Rule: Allow sorting by the trailing end of the module path

[berickson1]

PR checklist

• Addresses an existing issue: #0000
• New feature, bugfix, or enhancement
  • Includes tests
• Documentation update

Overview of change:

Add an additional argument to ordered-import rule allowing sorting by trailing end of path. This allows sorting modules with relative path by filename

CHANGELOG.md entry:

[enhancement] Allow sorting imports by trailing end of path

[palantirtech]

Thanks for your interest in palantir/tslint, @berickson1! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[ajafff]

Should probably handle imports from node_modules special. Otherwise sorting would be odd when using submodule imports or scoped modules:

import foo from "a/foo"
import bar from "b/bar"

[berickson1]

@ajafff is there an easy way to tell when importing from node_modules vs. relative?

[ajafff]

Take a look at noSubmoduleImportsRule.ts it contains such a condition:

tslint/src/rules/noSubmoduleImportsRule.ts

Line 85 in 7131f01

!(ts as any as {isExternalModuleNameRelative(m: string): boolean}).isExternalModuleNameRelative(expression.text) &&

[berickson1]

Done :)

[ajafff]

Code looks good.
I won't judge if this new option makes sense / is needed, because I don't like this rule at all.

[ajafff]

I'd prefer "full" and "basename"

[adidahiya]

I don't mind adding this option, but please rename the option names to "full" and "basename" as @ajafff suggested.

[adidahiya]

@berickson1 also let me know if you have any issues signing the CLA

[berickson1]

Sorry for the CLA delay - I had to get my employer's blessing first

[ajafff]

Thanks @berickson1