This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
This PR makes a switch from
colors.js
dependency to a similar, but modern librarychalk
. The motivation is to be able to force output coloring when runningtslint
as a forked process. Such migration allows to just add the environment variableFORCE_COLOR=1
.See also #3144, as it explains why I came to such changes. Both libraries have similar API, so most diff was automated by typescript's refactor ability.
Is there anything you'd like reviewers to focus on?
Note, there is WIP on bundling typescript definitions within chalk. For now, It seems enough to use current version of
@types/chalk
.Also, there is still a
colors.js
mention inyarn.lock
. Obviously, It should be gone away when you updatetslint
version indevDeps
.CHANGELOG.md entry:
chore: switch from
colors.js
tochalk