This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
prefer-object-spread: ignore Object.assign({}, this) #3126
Merged
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
suggested changes
Aug 14, 2017
src/rules/preferObjectSpreadRule.ts
Outdated
| * object types." | ||
| */ | ||
| if (node.arguments[1] !== undefined) { | ||
| if (node.arguments[1].kind === ts.SyntaxKind.ThisKeyword) { |
There was a problem hiding this comment.
that's not limited to the second argument. We should exit if any parameter to Object.assign is this similar to the check !node.arguments.some(isSpreadElement) above
src/rules/preferObjectSpreadRule.ts
Outdated
| /** | ||
| * @url https://github.com/palantir/tslint/issues/3117 | ||
| * Per TS2698, "spread types may only be created from | ||
| * object types." |
There was a problem hiding this comment.
also add a TODO to remove this when typescript get's support for spread types and a link to the PR (linked in the issue comments)
| @@ -1,3 +1,5 @@ | |||
| const form = Object.assign({}, this); | |||
There was a problem hiding this comment.
add a test for const foo = Object.assign({}, bar, baz, this);
ajafff
suggested changes
Aug 14, 2017
src/rules/preferObjectSpreadRule.ts
Outdated
| * object types." | ||
| * | ||
| */ | ||
| if (node.arguments.some((arg) => arg.kind === ts.SyntaxKind.ThisKeyword)) { |
There was a problem hiding this comment.
Can you please add this to the condition ending in line 62
| @@ -1,3 +1,5 @@ | |||
| const form = Object.assign({}, this); | |||
| const foo = Object.assign({}, bar, baz, this); | |||
There was a problem hiding this comment.
Needs another test: foo = Object.assign(bar, this);
ajafff
approved these changes
Aug 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of change:
Allows for Object.assign(obj, this)