Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

no-unused-variable: don't crash at destructuring #3058

Merged
merged 1 commit into from
Aug 2, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/rules/noUnusedVariableRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ function walk(ctx: Lint.WalkContext<void>, program: ts.Program, { checkParameter
const unusedCheckedProgram = getUnusedCheckedProgram(program, checkParameters);
const diagnostics = ts.getPreEmitDiagnostics(unusedCheckedProgram, sourceFile);
const checker = unusedCheckedProgram.getTypeChecker(); // Doesn't matter which program is used for this.
const declaration = program.getCompilerOptions().declaration;

// If all specifiers in an import are unused, we elide the entire import.
const importSpecifierFailures = new Map<ts.Identifier, string>();
Expand All @@ -118,7 +119,7 @@ function walk(ctx: Lint.WalkContext<void>, program: ts.Program, { checkParameter
if (kind === UnusedKind.VARIABLE_OR_PARAMETER) {
const importName = findImport(diag.start, sourceFile);
if (importName !== undefined) {
if (isImportUsed(importName, sourceFile, checker)) {
if (declaration && isImportUsed(importName, sourceFile, checker)) {
continue;
}

Expand Down Expand Up @@ -295,7 +296,9 @@ function isImportUsed(importSpecifier: ts.Identifier, sourceFile: ts.SourceFile,
}

function getImplicitType(node: ts.Node, checker: ts.TypeChecker): ts.Type | undefined {
if ((utils.isPropertyDeclaration(node) || utils.isVariableDeclaration(node)) && node.type === undefined) {
if ((utils.isPropertyDeclaration(node) || utils.isVariableDeclaration(node)) &&
node.type === undefined && node.name.kind === ts.SyntaxKind.Identifier ||
utils.isBindingElement(node) && node.name.kind === ts.SyntaxKind.Identifier) {
return checker.getTypeAtLocation(node);
} else if (utils.isSignatureDeclaration(node) && node.type === undefined) {
const sig = checker.getSignatureFromDeclaration(node);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { SomeClass, someVar } from "./some.test";
const person = { name: "alice" };
const { name } = person;
~~~~ ['name' is declared but never used.]

export const {prop} = someVar;
3 changes: 3 additions & 0 deletions test/rules/no-unused-variable/type-checked/some.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export class SomeClass {}

export const someVar = {prop: new SomeClass()};