-
Notifications
You must be signed in to change notification settings - Fork 885
Conversation
[new-rule] `no-parameter-reassign` Fixes: #3033
Looks awesome 🥇 I can't quite tell from the code... what did you end up deciding regarding destructured parameters? |
@benny-medflyt I decided to also check destructured parameters. I don't think it's necessary to add an option to disable that behavior until there is demand for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, but can you please rename this to no-parameter-reassignment
? we have a few existing rules that don't use the "reassign" abbreviation, so I'd like to stick to the convention of using the full word.
Renamed as suggested and fixed merge conflicts |
I think it is acceptable reassigning params which its type is number, string, boolean. It helps to write some algorithms easy. |
PR checklist
Overview of change:
[new-rule]
no-parameter-reassignment
Fixes: #3033
/cc @benny-medflyt
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry: