This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
object-literal-sort-keys: Add "match-declaration-order" option #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
approved these changes
Jul 31, 2017
There was a problem hiding this comment.
Mostly looks good. We can't close #2583 yet; do you intend to enable this new rule option in this repo?
It might be confusing that match-declaration-order applies to single-line literals but alphabetic ordering does not. We should at least document this subtle difference in the behavior (especially since alphabetic ordering is the fallback when a contextual type is not found).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
object-literal-sort-keys#2583Overview of change:
Added the
match-declaration-orderoption, which checks that object literals should match the order of property declarations in their contextual type.CHANGELOG.md entry:
[new-rule-option]:
object-literal-sort-keys: Addmatch-declaration-orderoption