-
Notifications
You must be signed in to change notification settings - Fork 885
Conversation
src/rules/noRedundantJsdocRule.ts
Outdated
} | ||
} | ||
|
||
declare module "typescript" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't do that
that should be done upstream in typescript. IIRC there's already an issue with a feature request for something like node.getJsDoc()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, let's wait for this to be fixed upstream.
src/rules/noRedundantJsdocRule.ts
Outdated
} | ||
} | ||
|
||
declare module "typescript" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, let's wait for this to be fixed upstream.
src/rules/noRedundantJsdocRule.ts
Outdated
} | ||
|
||
function isRedundantTag(tagName: string): boolean { | ||
switch (tagName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps keeping a Set
of these would be a little more efficient & less code?
@andy-hanson are you still interested in getting this merged? Since the If you don't want to continue here, just leave me a message if you are ok with me finishing your PR. |
PR checklist
Overview of change:
Adds the
no-redundant-jsdoc
rule, which forbids unnecessary redundant JSDoc, as in:CHANGELOG.md entry:
[new-rule]
no-redundant-jsdoc