This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fix semicolon rule on last line without EOF line. #2696
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Currently when using
"semicolon": [true, "never"]
rule if semicolon is used in last line without next EOF line then linting fails with error:because here
util.getNextToken()
return value is not tested forundefined
.I put tests in separate directory and not in
semicolon/never/test.ts.*
to avoid accidental appending to that files that will ruin this test.CHANGELOG.md entry:
[bugfix]
semicolon