This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Special case the empty string in object-literal-key-quotes rule #1762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
IDENTIFIER_NAME_REGEX
using a*
instead of+
repeat modifier. This has been addressed.''
in the"as-needed"
files.Is there anything you'd like reviewers to focus on?
I don't know enough about the spirit of "consistent" or "consistent-as-needed" to know if this case should be flagged as a failure or not:
Right now, this test fails in both cases. It seems like this is correct, but I welcome confirmation. Once I have it I'll update the tests.