Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Special case the empty string in object-literal-key-quotes rule #1762

Merged

Conversation

gustavderdrache
Copy link
Contributor

PR checklist

What changes did you make?

Is there anything you'd like reviewers to focus on?

I don't know enough about the spirit of "consistent" or "consistent-as-needed" to know if this case should be flagged as a failure or not:

const uncertain = {
  foo: 'bar',
  '': 'baz',
};

Right now, this test fails in both cases. It seems like this is correct, but I welcome confirmation. Once I have it I'll update the tests.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @gustavderdrache! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@nchen63 nchen63 merged commit 9a7d719 into palantir:master Nov 21, 2016
@nchen63
Copy link
Contributor

nchen63 commented Nov 21, 2016

@gustavderdrache thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants