This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Create local Error interface so that node doesn't need to be externally referenced #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xternally referenced
adidahiya
reviewed
Nov 18, 2016
| @@ -14,6 +14,8 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| export { Error } from "../configuration"; | |||
There was a problem hiding this comment.
Why does this compile? This import is just an interface, it doesn't define a call or constructor signature. I think L45 is still referencing node's Error constructor.
adidahiya
approved these changes
Nov 19, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem: when using TSLint as an NPM library, you see error:
Why: @types/node augments the
Errorinterface that was initially defined by TypeScript'slib.d.ts. Since the use of this interface is exported by TSLint, the app using TSLint must also include @types/node. Sadly, the property added by Node is currently already defined bylib.d.tsThe fix: Don't export the @types/node
Errorinterface and define/use our own similar interface.