Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Revert "Need to add @types/node to reg dependencies since we use Error interface" #1740

Merged
merged 1 commit into from
Nov 18, 2016

Conversation

adidahiya
Copy link
Contributor

Reverts #1739

@nchen63
Copy link
Contributor

nchen63 commented Nov 18, 2016

Yeah, it's not the right thing to do, but we should still address this error when compiling when tslint is installed as a library:

node_modules/tslint/lib/configuration.d.ts(1,1): error TS2688: Cannot find type definition file for 'node'.

@adidahiya
Copy link
Contributor Author

@nchen63 how exactly did you get that error -- did you set up a new test project? We could make a note in the docs

@nchen63 nchen63 merged commit b90c666 into master Nov 18, 2016
@nchen63
Copy link
Contributor

nchen63 commented Nov 18, 2016

Yeah, I set up a test project and installed from an npm pack package

@nchen63
Copy link
Contributor

nchen63 commented Nov 18, 2016

I feel like there should be a way to make it work that doesn't require users to install node typings. Pre-2.0 typescript did not generate the /// <reference types="node" /> header which causes this issue. If we can avoid exporting functions that use the Error interface, that would work too

@adidahiya adidahiya deleted the revert-1739-add-node-types branch November 18, 2016 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants