This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Removes no-duplicate-variable from the default & recommended configs
#1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/tslint, @elwayman02! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Per the [docs](https://palantir.github.io/tslint/rules/no-duplicate-variable/) for `no-duplicate-variable` itself: > This rule is only useful when using the var keyword - the compiler will detect redeclarations of let and const variables. Given that `no-var-keyword` is already included in both configs, `no-deuplicate-variable` becomes redundant since `var` will never be allowed in those configs.
adidahiya
approved these changes
Nov 14, 2016
|
Done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the docs for
no-duplicate-variableitself:Given that
no-var-keywordis already included in both configs,no-deuplicate-variablebecomes redundant sincevarwill never be allowed in those configs.