This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Use jsRules for JSX files #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. The error that told the user how to fix it was a nice touch |
|
@nchen63 thanks! I'll look for better alternative for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
New feature,bugfix,or enhancementWhat changes did you make?
This PR ensures that
jsRuleswill be used for both.jsand.jsxfiles. See #1634 (review)Is there anything you'd like reviewers to focus on?
Current
dedentimplementation isn't suitable for strings likeJS_ERROR_MESSAGEsince it calculates minimal indent for all lines and.join("\n")makes it 0.