This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Use denormalized path in test (fixes Windows build) #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchen63
reviewed
Nov 10, 2016
| @@ -123,10 +123,12 @@ describe("Executable", function() { | |||
| execCli(["-c", "test/files/multiple-fixes-test/tslint.json", tempFile, "--fix"], | |||
| (err, stdout) => { | |||
| const content = fs.readFileSync(tempFile, "utf8"); | |||
| // compare against file name which will be retyrned by formatter (used in TypeScript) | |||
nchen63
reviewed
Nov 10, 2016
| fs.unlinkSync(tempFile); | ||
| assert.strictEqual(content, "import * as y from \"a_long_module\";\nimport * as x from \"b\";\n"); | ||
| assert.isNull(err, "process should exit without an error"); | ||
| assert.strictEqual(stdout, `Fixed 2 error(s) in ${tempFile}`); | ||
| assert.strictEqual(stdout, `Fixed 2 error(s) in ${denornalizedFileName}`); |
|
@nchen63 thank you for review. Next time I will look more carefully to avoid such typos. |
|
@IllusionMH no problem. Thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
New feature,bugfix,or enhancementWhat changes did you make?
Currently build fails since normalized path returned from Node.js API (with
\as path separator) is compared to deormalized one (with/as path separator, which is also valid on Windows) which was picked from TypeScript.This PR fixes build on Windows by converting normalized path to denormalized and using it in comparison.
Is there anything you'd like reviewers to focus on?
I've reviewed 3 possible solutions:
Normalize
fileName's when they are stored inRuleFailureclass (used only in formatters)Normalize only absolute
fileName's when they are stored inRuleFailureclass (probably rare case, but matches problem in test)Use denormalized path in test
While first two solution fix problem, I think they bring almost no value and will lead to inconsistency in paths output between platforms.