This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Split CLI into tslint-cli and a Runner class #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👐 merge conflicts! I'll wait to resolve for if/until a design review passes. |
|
@nchen63 thanks for the ping, updated and renamed |
|
lgtm |
|
@JoshuaKGoldberg thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1675.
tslint-cli.ts takes in arguments using optimist and converts them to a friendlier object to pass to a CliRunner. The rest of the logic that used to be in tslint-cli.ts is now in the CliRunner.
Notes:
CliRunner::runreturn aPromise<number>, but didn't want to add new dependencies or change the output target.CliRunneras a name. Alternate suggestions, anyone?