This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Option added to no-consecutive-blank-lines #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an optional argument to no-consecutive-blank-lines rule to allow specifying maximum number of allowed blank lines instead of only allowing 1. By default, if no option is specified, the old value of 1 is used, thus the rule is fully backwards compatible. Similar to ESLint’s no-multiple-empty-lines rule “Max” option: http://eslint.org/docs/rules/no-multiple-empty-lines
nchen63
reviewed
Oct 28, 2016
| @@ -43,6 +67,9 @@ class NoConsecutiveBlankLinesWalker extends Lint.SkippableTokenAwareRuleWalker { | |||
| public visitSourceFile(node: ts.SourceFile) { | |||
| super.visitSourceFile(node); | |||
|
|
|||
| const options = this.getOptions(); | |||
| const allowedBlanks = options && options[0] || Rule.DEFAULT_ALLOWED_BLANKS; | |||
There was a problem hiding this comment.
should this match line 57? options is not an array
There was a problem hiding this comment.
No. Different hierarchy. In Rule classes, options property is IOptions. In the RuleWalker classes they are any[].
export class RuleWalker extends SyntaxWalker {
...
private options: any[];
...
constructor(private sourceFile: ts.SourceFile, options: IOptions) {
...
this.options = options.ruleArguments;
...
}
...
}
nchen63
approved these changes
Oct 28, 2016
|
Thanks @nomaed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional argument to
no-consecutive-blank-linesrule to allow specifying the maximum number of allowed blank lines to appear in sequence, instead of only allowing a hard limit of 1.If no option is specified, the old value of 1 is used, thus the rule is fully backwards compatible.
Similar to ESLint’s
no-multiple-empty-linesrule “Max” option:http://eslint.org/docs/rules/no-multiple-empty-lines