This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Adds semicolon option ignore-bound-class-methods
#1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/tslint, @nchen63! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
jkillian
suggested changes
Oct 31, 2016
| @@ -10,6 +10,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
this file update shouldn't be in this PR, it should only happen when you're updating the docs as a whole (on release)
| @@ -21,6 +21,7 @@ import * as Lint from "../lint"; | |||
|
|
|||
| const OPTION_ALWAYS = "always"; | |||
| const OPTION_NEVER = "never"; | |||
| const OPTION_ALLOW_BOUND_CLASS_METHODS = "allow-bound-class-methods"; | |||
There was a problem hiding this comment.
maybe it should be "skip-bound-class-methods"?
There was a problem hiding this comment.
oh wait, we already have an "ignore-interfaces" option, this should be "ignore-bound-class-methods" then
jkillian
reviewed
Nov 1, 2016
| @@ -21,6 +21,7 @@ import * as Lint from "../lint"; | |||
|
|
|||
| const OPTION_ALWAYS = "always"; | |||
| const OPTION_NEVER = "never"; | |||
| const OPTION_ALLOW_BOUND_CLASS_METHODS = "ignore-bound-class-methods"; | |||
jkillian
reviewed
Nov 1, 2016
allow-bound-class-methodsignore-bound-class-methods
jkillian
referenced
this pull request
in microsoft/TypeScript
Nov 4, 2016
…ut unnecessary semicolons following properties
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also changes default behavior by requiring semicolons to not come after bound class methods unless this setting is used
closes #1476