-
Notifications
You must be signed in to change notification settings - Fork 885
Compile with TypeScript 1.8.10 #1575
Conversation
We had to work around this too - we compile Angular using TS 1.9 internally. |
Update: I changed this PR to compile tslint with TS 1.8. This should fix the master branch. I tested the compiled linter with a peer of TS 2.0.3 and it still works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@@ -391,7 +391,7 @@ Creating a new release | |||
---------------------- | |||
<sup>[back to ToC ↑](#table-of-contents)</sup> | |||
|
|||
1. Bump the version number in `package.json`, `src/tslint.ts`, and `src/tslintMutli.ts` | |||
1. Bump the version number in `package.json` and `src/tslintMutli.ts` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling
Just so I understand, |
What is the timeline for compiling tslint with TS 2.0? |
@alexeagle I just released v4.0.0-dev.0, #1596 (unfortunately it includes some of the v4 breaking changes) -- would that work for your build? |
I still need the local modification to uncomment lines prefixed with "include this field when compiling with TS 2.0" but it's not a big deal. |
that release comes from the |
Breaking changes in compiler APIs broke the master branch. This is a simple workaround to get compilation working, but it forces us to depend on TS 2.0 (it doesn't compile with TS 1.8).
What do you think about bumping the peer dependency @jkillian?