Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Compile with TypeScript 1.8.10 #1575

Merged
merged 3 commits into from
Sep 26, 2016
Merged

Compile with TypeScript 1.8.10 #1575

merged 3 commits into from
Sep 26, 2016

Conversation

adidahiya
Copy link
Contributor

Breaking changes in compiler APIs broke the master branch. This is a simple workaround to get compilation working, but it forces us to depend on TS 2.0 (it doesn't compile with TS 1.8).

What do you think about bumping the peer dependency @jkillian?

@alexeagle
Copy link
Contributor

We had to work around this too - we compile Angular using TS 1.9 internally.
https://github.com/angular/angular/blob/979657989bab4fb93faf6a207d30760faa9bd696/tools/%40angular/tsc-wrapped/src/tsc.ts#L70

@adidahiya adidahiya changed the title TypesScript 2.0 compatibility Compile with TypeScript 1.8.10 Sep 26, 2016
@adidahiya
Copy link
Contributor Author

Update: I changed this PR to compile tslint with TS 1.8. This should fix the master branch. I tested the compiled linter with a peer of TS 2.0.3 and it still works.

Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@@ -391,7 +391,7 @@ Creating a new release
----------------------
<sup>[back to ToC &uarr;](#table-of-contents)</sup>

1. Bump the version number in `package.json`, `src/tslint.ts`, and `src/tslintMutli.ts`
1. Bump the version number in `package.json` and `src/tslintMutli.ts`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling

@adidahiya adidahiya merged commit d8ad052 into master Sep 26, 2016
@adidahiya adidahiya deleted the ad/ts-2.0 branch September 26, 2016 22:39
@jkillian
Copy link
Contributor

Just so I understand, getDirectories is required by the TS 2.0 typings, but not really required at runtime, so TS 2.0 is fine as a peer? (And a similar story with fileExists?)

@alexeagle
Copy link
Contributor

What is the timeline for compiling tslint with TS 2.0?
Internally we use a single TS version for all compilation, which means I can't sync unmodified tslint into our third party libraries anymore.

@adidahiya
Copy link
Contributor Author

@alexeagle I just released v4.0.0-dev.0, #1596 (unfortunately it includes some of the v4 breaking changes) -- would that work for your build?

@alexeagle
Copy link
Contributor

I still need the local modification to uncomment lines prefixed with "include this field when compiling with TS 2.0" but it's not a big deal.

@adidahiya
Copy link
Contributor Author

that release comes from the next branch, which does compile with 2.0, so it includes the new compiler host options: https://github.com/palantir/tslint/blob/next/src/language/utils.ts#L32

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants