Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

fix: do not flag nested or .d.ts namespaces. #1571

Merged
merged 1 commit into from
Nov 3, 2016
Merged

fix: do not flag nested or .d.ts namespaces. #1571

merged 1 commit into from
Nov 3, 2016

Conversation

mprobst
Copy link
Contributor

@mprobst mprobst commented Sep 23, 2016

Note: I've been unable to test this properly as on my machine grunt for some reason picks up tsc 2.0.3, which fails to compile tslint.

@mprobst
Copy link
Contributor Author

mprobst commented Nov 2, 2016

Friendly ping?

adidahiya
adidahiya approved these changes Nov 3, 2016
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks. I'll resolve any build errors that come up after this merges.

@adidahiya adidahiya merged commit a5cdd8c into palantir:master Nov 3, 2016
@mprobst mprobst deleted the ambient-namespace branch November 3, 2016 14:23
@mprobst
Copy link
Contributor Author

mprobst commented Nov 3, 2016

Thanks @adidahiya!

@nchen63 nchen63 added this to the TSLint v4.0 milestone Nov 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
TSLint v4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mprobst @adidahiya @nchen63