Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix misleading example for 'file-header' #1536

Merged
merged 4 commits into from Sep 1, 2016
Merged

Fix misleading example for 'file-header' #1536

merged 4 commits into from Sep 1, 2016

Conversation

ghost
Copy link

@ghost ghost commented Sep 1, 2016

Old example was wrong (braces missing, regex wrong) and therefore misleading

Old example for file-header: "file-header": "true", "Copyright \d{4}"
New example for file-header: "file-header": [true, "Copyright \\d{4}]"

Old example was wrong (braces missing, regex wrong) and therefore misleading
@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @christiandreher! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@ghost ghost changed the title Fix misleading example Fix misleading example for 'file-header' Sep 1, 2016
@ScottSWu
Copy link
Contributor

ScottSWu commented Sep 1, 2016

I think the docs are generated, so the problem is in the original rule source: https://github.com/palantir/tslint/blob/master/src/rules/fileHeaderRule.ts#L14

@ghost
Copy link
Author

ghost commented Sep 1, 2016

Oh, I'm sorry, I didn't know that. I will update the PR then asap. Thank you for pointing that out.

Revert changes since those are auto-generated
@ghost
Copy link
Author

ghost commented Sep 1, 2016

I reverted the changes on the docs, resulting in 3 unnecessary commits. You can deny this PR and I'll do a proper one if you want

@adidahiya
Copy link
Contributor

@christiandreher this is fine, we squash + merge on Github anyway.

👍

@adidahiya adidahiya merged commit 49e75d7 into palantir:master Sep 1, 2016
@ghost
Copy link
Author

ghost commented Sep 1, 2016

Nice, thanks for that quick feedback

@ghost ghost deleted the patch-1 branch September 1, 2016 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants