Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Adding "allow-declarations" to only-arrow-functions #1452

Merged
merged 12 commits into from
Aug 9, 2016
Merged

Adding "allow-declarations" to only-arrow-functions #1452

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
54359f9
Merge remote-tracking branch 'refs/remotes/palantir/master'
Apr 22, 2016
d6857cf
Merge remote-tracking branch 'refs/remotes/palantir/master'
Apr 26, 2016
54fe0fb
Merge remote-tracking branch 'refs/remotes/palantir/master'
Apr 27, 2016
b32ceb5
Merge branch 'master' of https://github.com/JoshuaKGoldberg/tslint
Jun 22, 2016
4b5c9e6
Merge branch 'master' of https://github.com/palantir/tslint
Aug 2, 2016
c8e083f
Added only-arrow-functions "allow-declarations"
Aug 2, 2016
c3b4eaf
Fixed tslint violation with quotemarks
Aug 8, 2016
87381dc
Merged branch master into some-non-arrow-functions
Aug 9, 2016
e8d0aba
Renamed only-arrow-functions full->default tests
Aug 9, 2016
a55f6d6
Simplified option check in OnlyArrowFunctionsWalker
Aug 9, 2016
47cf778
Fixed a stray README.md newline
Aug 9, 2016
be8cccf
Fixed OnlyArrowFunctionsWalker inverted logic check
Aug 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rules/onlyArrowFunctionsRule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export class Rule extends Lint.Rules.AbstractRule {

class OnlyArrowFunctionsWalker extends Lint.RuleWalker {
public visitFunctionDeclaration(node: ts.FunctionDeclaration) {
if (this.getOptions().indexOf(OPTION_ALLOW_DECLARATIONS) === -1) {
if (this.hasOption(OPTION_ALLOW_DECLARATIONS)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, I should have suggested !this.hasOption, I think the logic got inverted here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm.

this.addFailure(this.createFailure(node.getStart(), "function".length, Rule.FAILURE_STRING));
}
super.visitFunctionDeclaration(node);
Expand Down