This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Issue #1054 - Ported the use-isnan rule from tslint-microsoft-contrib… #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to tslint Closes #1054
|
It's not clear to me where to update your documentation pages. Do I need to do that as well? |
|
Don't worry about the documentation pages - I normally update those once a release with the changes gets published. |
| import * as ts from "typescript"; | ||
| import * as Lint from "../lint"; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Do you mean the block comment and copyright notice? Or the JSDoc?
There was a problem hiding this comment.
I meant the JSDoc, but actually it doesn't hurt, you can just leave it 👍
|
Thanks @HamletDRC, this PR looks great! Could you just make the super minor tweaks mentioned above before it merges? |
|
Great. Thanks. |
|
This is now failing for: let x = 0;
x = NaN; |
|
Uh-oh! Thanks for the heads-up @dasa |
|
sending pull request #1185 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to tslint
Closes #1054