This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Clearer message for no-var-keyword rule
#1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just telling someone what they can't do, give suggestions about how to fix it and what they should do as an alternative. Currently the rule `no-var-keyword` complains with >forbidden var keyword But that really doesn't help, especially if someone is new to TypeScript and is not even aware that `let` and `const` are possibilities. Now it will complain with this message >forbidden 'var' keyword, use 'let' or 'const' instead
|
lgtm 👍 thanks @ChrisMBarr! |
|
Awesome! Should this also be put in the 3.8 milestone? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just telling someone what they can't do, give suggestions about how to fix it and what they should do as an alternative.
Currently the rule
no-var-keywordcomplains withBut that really doesn't help, especially if someone is new to TypeScript and is not even aware that
letandconstare possibilities.Now it will complain with this message