JS directives are not unused expressions #1094

jkillian · 2016-04-06T18:35:12Z

adidahiya · 2016-04-06T18:57:14Z

src/rules/noUnusedExpressionRule.ts


-            if (!isValidStandaloneExpression && !isValidStringExpression) {
+            if (!isValidStandaloneExpression && !isValidDirective) {


nit: I would just inline the call to isDirective(node)

adidahiya · 2016-04-06T18:57:26Z

👍

jkillian mentioned this pull request Apr 6, 2016

no-unused-expression rule doesn't handle directives #1050

Closed

JS directives are not unused expressions

0c0d9f3

jkillian force-pushed the directives branch from 48844d1 to 0c0d9f3 Compare April 6, 2016 18:38

adidahiya reviewed Apr 6, 2016
View reviewed changes

simplify directive handling slightly

bf90340

adidahiya merged commit 390ac95 into master Apr 7, 2016

jkillian deleted the directives branch April 12, 2016 14:47

ArturDorochowicz mentioned this pull request Apr 24, 2016

Recognize directives in class constructors and properties. #1159

Merged

Provide feedback


		if (!isValidStandaloneExpression && !isValidStringExpression) {
		if (!isValidStandaloneExpression && !isValidDirective) {