Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Running tests is much slower now that type checking is always enabled #1402

Closed
adidahiya opened this issue Jul 14, 2016 · 1 comment · Fixed by #1403
Closed

Running tests is much slower now that type checking is always enabled #1402

adidahiya opened this issue Jul 14, 2016 · 1 comment · Fixed by #1403
Labels
Domain: Unit Testing

Comments

@adidahiya
Copy link
Contributor

As a result of #1363.
@adidahiya
Copy link
Contributor Author

Proposal: allow configuration of type checking from tslint.json with a new field:

"linterOptions": {
    "typeCheck": true
}

src/test.ts would then only call ts.getPreEmitDiagnostics if this option was configured.

adidahiya added a commit that referenced this issue Jul 14, 2016
@adidahiya
Add linterOptions to tslint.json
d7098b1 
- only enable type checking during tests when typeCheck: true is configured
- fixes #1402
@adidahiya adidahiya mentioned this issue Jul 14, 2016
Merged
jkillian pushed a commit that referenced this issue Jul 19, 2016
@adidahiya @jkillian
Add linterOptions to tslint.json (#1403)
7fbd31b 
* Add linterOptions to tslint.json

- only enable type checking during tests when typeCheck: true is configured
- fixes #1402

* Code style
soniro pushed a commit to soniro/tslint that referenced this issue Aug 31, 2016
@adidahiya
Add linterOptions to tslint.json (palantir#1403)
6b056cc 
* Add linterOptions to tslint.json

- only enable type checking during tests when typeCheck: true is configured
- fixes palantir#1402

* Code style
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Domain: Unit Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add linterOptions to tslint.json palantir/tslint
1 participant
@adidahiya